Add Yarn v2 Plug and Play .pnp.cjs handler support#4875
Closed
hashaam-011 wants to merge 1 commit intoaboutcode-org:developfrom
Closed
Add Yarn v2 Plug and Play .pnp.cjs handler support#4875hashaam-011 wants to merge 1 commit intoaboutcode-org:developfrom
hashaam-011 wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
hashaam-011
force-pushed
the
yarn-pnp-support
branch
from
895ca57 to
47c6e6f
Compare
Signed-off-by: hashaam-011 <hashaamkhan975@gmail.com>
|
|
||
| package.keywords = keywords | ||
| return package | ||
| class YarnPnpHandler(BaseNpmHandler): |
Member
There was a problem hiding this comment.
No tests are added, manifest handler is not activated.
Please don't open PRs which don't have enough code to be reviewed, this is not useful and wastes time.
Member
|
Closing as spam. |
Author
|
Hi @AyanSinhaMahapatra , Apologies for the premature PR. I understand it lacked tests and the handler wasn't activated — that was my oversight. I'll work on adding proper tests and registering the handler before opening a new PR. I'll also make sure the submission is complete and ready for review this time. Thank you for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2728
Added a new YarnPnpHandler class in npm.py to support Yarn v2
Plug and Play .pnp.cjs files.
Changes:
Tested locally by parsing a sample .pnp.cjs file.